Fix investigation policy select value - #1001
Closed
taobojlen wants to merge 1 commit into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
taobojlen
force-pushed
the
fix/investigation-tag-key-warning
branch
from
August 12, 2026 03:05
0d7bdb8 to
a3f0d33
Compare
taobojlen
force-pushed
the
fix/investigation-policy-select-value
branch
from
August 12, 2026 03:05
c5debae to
32c1c05
Compare
taobojlen
force-pushed
the
fix/investigation-tag-key-warning
branch
from
August 12, 2026 03:42
a3f0d33 to
f8a018d
Compare
taobojlen
force-pushed
the
fix/investigation-policy-select-value
branch
from
August 12, 2026 03:42
32c1c05 to
538d54e
Compare
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fec69-19ab-77e8-b6f0-85af1ed67eed
taobojlen
force-pushed
the
fix/investigation-policy-select-value
branch
from
August 17, 2026 10:22
538d54e to
2da1d55
Compare
taobojlen
force-pushed
the
fix/investigation-tag-key-warning
branch
from
August 17, 2026 10:22
f8a018d to
1f9ef07
Compare
taobojlen
changed the base branch from
fix/investigation-tag-key-warning
to
main
August 17, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
Tests
(Optional) Rollout Plan
Checklist
Only check items that apply to this PR; leave the rest unchecked.
If you changed anything user-facing (i.e. user interface or APIs):
Did you update the CHANGELOG.md and related docs?
If you changed
server/models/**/{ContentTypeModel,ActionModel,RuleModel,PolicyModel}.ts:Did you update the corresponding history tables and their triggers?
If you changed
db/src/scripts/**and usedCREATE TABLE,ADD COLUMN, orALTER COLUMN:Are as many columns marked
NOT NULLas possible? If some columns can sometimes be null depending on other columns, are thereCHECKconstraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?If you added a new signal in
server/services/signalsService/signals/**:Did you classify every error case as a permanent error (
SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be aSignalPermanentError.